Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialogs] Fix incorrectly stored files in GIT LFS #9892

Conversation

galiak11
Copy link
Contributor

@galiak11 galiak11 commented Mar 13, 2020

Description

Two snapshot images were not correctly stored in Git LFS, resulting in errors when cloning the repository.

Error

Encountered 2 file(s) that should have been pointers, but weren't:
snapshot_test_goldens/goldens_64/MDCAlertControllerActionsTests/testActionsLayoutHorizontallyForCatpitalizedButtonCase_11_2@2x.png
snapshot_test_goldens/goldens_64/MDCAlertControllerActionsTests/testVerticalActionsAreOrderedByEmphasis_11_2@2x.png

Solution

git lfs migrate import --no-rewrite <files>

…erticalActionsAreOrderedByEmphasis_11_2@2x.png,snapshot_test_goldens/goldens_64/MDCAlertControllerActionsTests/testActionsLayoutHorizontallyForCatpitalizedButtonCase_11_2@2x.png: convert to Git LFS
@galiak11 galiak11 requested a review from a team as a code owner March 13, 2020 08:55
@galiak11 galiak11 requested a review from jverkoey March 13, 2020 09:02
@galiak11 galiak11 changed the title snapshot_test_goldens/goldens_64/MDCAlertControllerActionsTests/testV… [Dialogs] Fix incorrectly stored files in GIT LFS Mar 13, 2020
@galiak11 galiak11 requested review from jverkoey and removed request for jverkoey March 13, 2020 12:31
@jverkoey
Copy link
Contributor

It looks like the git lfs files are still being incorrectly uploaded here based on the fact that they're not loading. Is this expected?

@galiak11 galiak11 requested a review from fluxminds March 13, 2020 13:13
@galiak11
Copy link
Contributor Author

I’ve followed similar PRs addressing this issue. For example - #8651

@andrewoverton
Copy link
Contributor

I ran the same command in #9862 to fix incorrectly stored snapshots, and I too was concerned when I couldn't preview them after. I ended up just renaming the test and regenerating the snapshots to be on the safe side, but I think it's worth merging this PR as it stands now to see if it actually does address the issue. I think it does.

Copy link
Contributor

@jverkoey jverkoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on @andrewoverton's context.

@galiak11 galiak11 merged commit 55de801 into material-components:develop Mar 13, 2020
jverkoey pushed a commit that referenced this pull request Mar 16, 2020
…ts/testVerticalActionsAreOrderedByEmphasis_11_2@2x.png,snapshot_test_goldens/goldens_64/MDCAlertControllerActionsTests/testActionsLayoutHorizontallyForCatpitalizedButtonCase_11_2@2x.png: convert to Git LFS (#9892)"

This reverts commit 55de801.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants