Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialogs] Refactoring alert actions test #9886

Merged
merged 1 commit into from
Mar 12, 2020
Merged

[Dialogs] Refactoring alert actions test #9886

merged 1 commit into from
Mar 12, 2020

Conversation

galiak11
Copy link
Contributor

Description

Simplifying names of action methods.

Issue

b/137070719, cl/299739784

@galiak11 galiak11 requested a review from iberezan as a code owner March 12, 2020 09:24
@material-automation
Copy link

material-automation commented Mar 12, 2020 •
edited
Loading

bazel detected changes to the following targets:

//components/Dialogs:snapshot_test_lib
//components/Dialogs:snapshot_tests
//components/Dialogs:snapshot_tests.swift_runtime_linkopts
//components/Dialogs:snapshot_tests_test_binary
//components/Dialogs:snapshot_tests_test_bundle

1 similar comment
@material-automation
Copy link

bazel detected changes to the following targets:

//components/Dialogs:snapshot_test_lib
//components/Dialogs:snapshot_tests
//components/Dialogs:snapshot_tests.swift_runtime_linkopts
//components/Dialogs:snapshot_tests_test_binary
//components/Dialogs:snapshot_tests_test_bundle

@galiak11
[Dialogs] Refactoring alert actions test
21fcdf3 
Issue: b/137070719, cl/299739784
PiperOrigin-RevId: 299739784
@galiak11 galiak11 force-pushed the refactor_sctions_snapshots branch from b17469f to 21fcdf3 Compare March 12, 2020 09:39
@galiak11 galiak11 requested a review from a team as a code owner March 12, 2020 09:39
@galiak11 galiak11 requested review from jverkoey and fluxminds March 12, 2020 09:45
@galiak11 galiak11 merged commit 9febb9d into material-components:develop Mar 12, 2020
jverkoey pushed a commit that referenced this pull request Mar 16, 2020
Revert "[Dialogs] Refactoring alert actions test (#9886)"
184834c 
This reverts commit 9febb9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jverkoey jverkoey jverkoey approved these changes

@iberezan iberezan Awaiting requested review from iberezan

@fluxminds fluxminds Awaiting requested review from fluxminds

Assignees
No one assigned
Labels
cla: yes [Dialogs]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galiak11 @material-automation @jverkoey @googlebot