[Chips] Add MDCChipField snapshot test to show placeholder width is being miscalculated #9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if no placeholder is present
|
bazel detected changes to the following targets: |
jverkoey
approved these changes
Mar 5, 2020
| @@ -108,6 +108,21 @@ - (void)testTextFieldWithZeroMinimumWidthIsOnSameLineAsWideChips { | |||
| [self snapshotVerifyView:self.chipField]; | |||
| } | |||
|
|
|||
| - (void)testEmptyPlaceholderSizeDoesNotAccountForContentInsets { | |||
There was a problem hiding this comment.
Will this test title be accurate once the issue is fixed? I'd expect this test to eventually be "testEmptyPlaceholderSizeAccountsForContentInsets"; may be better to have the right name with the wrong screenshot so that when you fix it the screenshot matches the name.
There was a problem hiding this comment.
Yep! Right now, this title is inaccurate and is exposing a bug. An empty placeholder should not account for insets in its requested size, but should only require the minimum hit target size. A PR to fix this will be published immediately after this one lands :)
andrewoverton
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a snapshot test to demonstrate #9846