-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chips] Move MDCChipField text input to a new line if text is too wide #9845
[Chips] Move MDCChipField text input to a new line if text is too wide #9845
Conversation
bazel detected changes to the following targets:
|
bazel detected changes to the following targets:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No affected test?
Also: love the clarity of this code. Thank you! 🙏
As mentioned in the other thread, I'm somewhat under the UX impression that the chip input text field should always be on a newline to avoid the jumping behavior being coded here, but am not blocking this PR in terms of it being an iterative improvement. |
@jverkoey This is kind of tough to test – setting the text programmatically (vs. entering it via keyboard) causes a layout pass, which masks the bug in snapshot tests. Is there a good way to simulate keyboard input? If so, I'll write a couple tests and land those before this PR. |
Hmm we don't have any tests that I'm aware of that do text input simulation, so that may be a reasonable thing to file as a follow-up issue. |
Updates MDCChipField to move the internal text field down to a new line if:
Fixes #9006
This completes the roll-forward of #9828
Before:

After:
