Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chips] Update MDCChipCollectionViewFlowLayout to respect sectionInset #9813

Merged
merged 1 commit into from
Feb 28, 2020
Merged

[Chips] Update MDCChipCollectionViewFlowLayout to respect sectionInset #9813

merged 1 commit into from
Feb 28, 2020

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Feb 27, 2020 •
edited
Loading

Use sectionInset.left as the x origin for MDCChipCollectionViewFlowLayout rows. The snapshot test affected by this change sets collectionViewLayout.sectionInset = UIEdgeInsetsMake(20, 20, 0, 20).

Fixes #7597

@bryanoltman bryanoltman requested a review from a team February 27, 2020 21:55
@material-automation
Copy link

material-automation commented Feb 27, 2020 •
edited
Loading

bazel detected changes to the following targets:

//components/Chips:snapshot_tests
//components/Chips:snapshot_tests_test_bundle
//components/Chips:unit_tests
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Chips:unit_tests_environment
//components/Chips:unit_tests_environment_test_bundle

@bryanoltman bryanoltman requested a review from yarneo February 28, 2020 14:56
@bryanoltman bryanoltman merged commit 8daed7f into material-components:develop Feb 28, 2020
@bryanoltman bryanoltman deleted the MDCChipCollectionViewFlowLayout-sectionInset-fix branch February 28, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewoverton andrewoverton andrewoverton approved these changes

@yarneo yarneo Awaiting requested review from yarneo

Assignees
No one assigned
Labels
[Chips] cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chips] Internal issue: b/135212358
4 participants
@bryanoltman @material-automation @andrewoverton @googlebot