Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scripts] Stop installing contributor tools for CI builds #1804

Merged
merged 1 commit into from
Aug 15, 2017
Merged

[Scripts] Stop installing contributor tools for CI builds #1804

merged 1 commit into from
Aug 15, 2017

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Aug 15, 2017

The Travis-CI .yaml script currently installs all of our "contributor
tools" before building. These tools are not needed for continuous
integration builds, which target unit tests and code coverage.

The Travis-CI .yaml script currently installs all of our "contributor
tools" before building.  These tools are not needed for continuous
integration builds, which target unit tests and code coverage.
@romoore romoore added the type:Internal cleanup Refactoring work is required. label Aug 15, 2017
@codecov-io
Copy link

codecov-io commented Aug 15, 2017

Codecov Report

Merging #1804 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1804      +/-   ##
===========================================
- Coverage    42.37%   42.37%   -0.01%     
===========================================
  Files          193      193              
  Lines        15461    15461              
  Branches      1593     1593              
===========================================
- Hits          6552     6551       -1     
- Misses        8364     8365       +1     
  Partials       545      545
Impacted Files Coverage Δ
components/private/ThumbTrack/src/MDCThumbTrack.m 45.25% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155a397...22f6d87. Read the comment docs.

@willlarche willlarche removed their assignment Aug 15, 2017
@willlarche willlarche changed the title Stop installing contributor tools for CI builds [Scripts] Stop installing contributor tools for CI builds Aug 15, 2017
Copy link
Contributor

@ajsecord ajsecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think they were required at some point, 🤷‍♂️

@romoore romoore merged commit 0a6825b into material-components:develop Aug 15, 2017
@romoore romoore deleted the travis-notools branch December 11, 2017 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Scripts type:Internal cleanup Refactoring work is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants