[Snackbar] Fix glitchy snackbar dismissal animation #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Consider swapping constraints to animate the view on / off the screen. |
Current coverage is 28.79% (diff: 0.00%)
|
samnm
force-pushed
the
snackbar-glitch-fix
branch
from
df26ea5 to
695ce3b
Compare
Contributor
Author
|
Changed the implementation to use constraint animation instead :) |
ianegordon
approved these changes
Jan 20, 2017
Contributor
ianegordon
left a comment
ianegordon
left a comment
There was a problem hiding this comment.
Tested on iPhone 6 Plus sim.
Snackbar disappears without the visual glitch on complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the glitchy snackbar animation by holding on to each animation after it is completed.
Tested on device with rotation.
Closes #1018.