[AppBar] Header stack view in AppBarController #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet.
ajsecord
approved these changes
Jan 3, 2017
Current coverage is 28.86% (diff: 100%)@@ develop #1121 diff @@
==========================================
Files 124 124
Lines 12868 12868
Methods 1699 1699
Messages 0 0
Branches 1007 1007
==========================================
+ Hits 3713 3714 +1
+ Misses 9143 9142 -1
Partials 12 12
|
ianegordon
reviewed
Jan 3, 2017
| // It previously replaced loadViewIfNeeded call that is only iOS 9.0+ to | ||
| // make backwards compatible. | ||
| // Underlying issue is you need view loaded before accessing. Below change will accomplish that | ||
| // by calling for view.bounds initializing the stack view |
Contributor
There was a problem hiding this comment.
If we are pulling out self.view, should we also update the comment immediately above?
Collaborator
Author
|
Good catch
On Tue, Jan 3, 2017 at 11:34 ianegordon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In components/AppBar/src/MDCAppBar.m
<#1121 (review)>
:
> @@ -151,7 +151,7 @@ - (MDCHeaderStackView *)headerStackView {
// Underlying issue is you need view loaded before accessing. Below change will accomplish that
// by calling for view.bounds initializing the stack view
If we are pulling out self.view, should we also update the comment
immediately above?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1121 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNm5Zg_wn9pw4pokKjQ_D-ikOpohop-ks5rOniagaJpZM4LZvlf>
.
--
Will Larche
iOS Software Engineer
Material Design
Google, Inc.
|
brianjmoore
pushed a commit
to brianjmoore/material-components-ios
that referenced
this pull request
Jan 3, 2017
* [Docs] Add hero image to top-level README.md (material-components#1100) * Added hero image. * Added retina-sized hero image. * Add `srcset` image tag. * Flow image to the right. * Update README.md * Fixed srcset, duh. * Update README.md * Update README.md * Gave up on srcset+markdown for now. * Update README.md * Update README.md * Increased image size. * Remove redundant RTL frame adjustment (material-components#1103) * Made build/test scripts exit with failure if anything failed. (material-components#1088) * [ReadMes] - First image of each component is too big (material-components#1110) * MDC_#917 - Activity Indicator Readme Update * MDC_#917 - Updated remaining readme image links * MDC_#917 - Fixed typo * [Site] Removing unused files for and from generated doc site. (material-components#1108) * [ReadMes] - Updated asset name for collection_cells (material-components#1111) * Enable Travis CI integration (material-components#1095) * Add file to kick off Travis * Checking Travis CI's installed Xcode and simulator devices. * Adding Cocoapods init to Travis CI config. * Enabling building in Travis CI config. * Added temporary dumping of the log file on error. * Switched Shrine to manual signing. * Dump Travis code signing options. * Adding CocoaPods version to debug output. * Remove code signing reporting from Travis CI config. * Forcing `build_all` to skip code signing. * Switching Shrine back to automatic provisioning style. * Re-enabling testing in Travis CI. * Bump up verbosity of testing. * Changing test device from 10.2 to 10.1 to work around Travis CI bug. * Remove the printing of available devices, Xcode will print them out on error. * Added more context on failure for Travis CI builds only. * Re-enable CI for our normal branches. * Remove "do not merge" file. * Removing our development team and switching Catalog to automatic profiles. * Removing our development team and switching Bare to automatic profiles. * Removing our development team and switching Pesto to automatic profiles. * Add Travis CI build badge to README.md (material-components#1112) * Add uploading of testing code coverage results to codecov.io (material-components#1114) This won't do anything yet, but once we start emitting code coverage files it will. * Enable test code coverage reports in Xcode and in Travis CI. (material-components#1115) * Add codecov.io badge to README.md. (material-components#1116) * Add Codecov config to exclude uninteresting paths. (material-components#1118) * Extracts header code into method removing repetition (material-components#1119) * [AppBar] Header stack view in AppBarController (material-components#1121) Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet. * Initial implementation of MDCTabBar and private MDCItemBar (material-components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * Initial implementation of MDCTabBar and private MDCItemBar (material-components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * [Tabs] Initial README template and changes * [Tabs] Updating intro content. * [Tabs] Commenting out mention of bottom navigation bars in readme. * [Tabs] Overview written * [Tabs] Correcting resources key in pod spec. * [Tabs] Correcting implementation of resources key in pod spec. * [Tabs] Mentioning badges in overview. * [Tabs] Removing TODO in ready. * [Tabs] Removing duplicate entry in pod spec (cherry pick artifact.) * [Tabs] Duplicating tabs example in prep for splitting it into two. * [Tabs] Examples crudely split apart. * [Pods] Update of lock, catalog and tests for new version. * [Tabs] Refactored examples to be in style of supplemented examples. * [Tabs] Formatting. * [Tabs] Formatting. * [Tabs] Formatting. * Add usage examples * Add usage examples * Update import documentation * Small edits * Do not show badges for title-only tabs Also updates the text-only example to toggle upcasing rather than increment non-existent badges. * Update title-only documentation re: badges * Update README.md * Update Podfile.lock * Manually fix Podfile.lock
kul3r4
pushed a commit
to kul3r4/material-components-ios-1
that referenced
this pull request
Jan 18, 2017
jgunaratne
pushed a commit
that referenced
this pull request
Jan 18, 2017
* Extracts header code into method removing repetition * [AppBar] Header stack view in AppBarController (#1121) Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet. * [ThumbTrack] Remove extra UIColor categories (#1122) * Pull the functionality of UIColor+MDC into MDCThumbTrack. MDCThumbTrack is now the only class using this behaviour, so three extra files have been removed now that they are no longer necessary. * Fixed colon alignment. * [Ink] Add nonnull to the MDCInkTouchController initializer (#1123) * Specify `nonnull` on the MDCInkTouchController initializer. This is a quick change since the initializer was never returning nil to begin with. * Update Shrine to use the nonnull MDCInkTouchController initializer. * Formatted all Objective-C sources with clang-format. (#1133) * [Scripts] Add scripts for "prepping" and cleaning the library/catalog/demo apps. (#1130) * Changed build_all to echo the xcodebuild command it is executing. * Added a clean_all script. * Added a prep_all script. * Updated README.md with new scripts. * Change Travis CI to use the new `prep_all` script. * Added a script to format Objective-C sources with clang-format. (#1132) * Added comment about Travis CI's 10.1 device bug. (#1135) * Removed the private/Color subspec. (#1128) * [Catalog] Center views in the Buttons (Swift and Storyboard) demo (#1126) * Center the Storyboard button demo. This uses an outer container to set up a view which is 50% the screen width (to allow for the other half of the button demo), and then an inner container to vertically and horizontally center the buttons. * Center the buttons added programatically. * Weakify strongify asynchronously dispatched snackbar view dismissal (#1136) * Update the button’s custom title color when the tint color changes. (#1134) * Add travis_wait prefixes on long-running commands. * Render Snackbar labels correctly for RTL (#1137) * Change the MDCInteractionTest deployment target to 8.0. (#1131) * Turn `inkController` into a lazy var. (#1139) This removes the need for storing it as an optional. * [ProgressView] Backward animation support (#1138) * Add backward progress animation mode support. This allows users to animate the progress view backward if they are giving it progress which is lesser than the current value. * Demonstrate the backward progress animation support. * Update the assets for the progress view. * Change ProgressViewExample with new enum name. * Updated enum names. * Update with new enum names. * Added script to install SwiftLint. (#1143) * Ran scripts/format_all. (#1141) * [Scripts] SwiftLint integration (#1129) * Integrate SwiftLint in the Catalog. * Update the disabled SwiftLint rules. * Reference a local swiftlint.yml symlink. This prevents us from getting warnings about code style violations from the other demos. * Fix SwiftLint violations in the Catalog and Components. * Ignore the `third_party` directory when running the linter. We should not have to deal with warnings in code we may not be able to fix easily. * Integrate SwiftLint into Shrine. Additionally, fix a number of warnings introduced. * Run SwiftLint on Travis. * Enable many of the previously disabled rules and correct them. * Fix control statement violations from SwiftLint. * Update README.md * Ignore "error" from already-installed brew packages. * [FlexibleHeader] - Update tests so as not to have 0 in contentSize (#1146) * Fixed broken links to versions.md. * Added component changes to CHANGELOG.md. * Added API diff, determined new version number is 20.0.0. * Bumped version number to 20.0.0. * Tell `brew install` to stop failing if swiftlint is already installed. * Changed clean script to force-clean Xcode projects. (#1144) * Fix SwiftLint warnings (#1149) * Exclude catalog/third_party from SwiftLint. * Added line length to .swiftlint.yml * Fixed SwiftLint warnings with some minor refactors. * Install SwiftLint via the install_contributor_tools script. (#1145) * Install SwiftLint via the install_contributor_tools script. * Exclude catalog/third_party from SwiftLint. * Added line length to .swiftlint.yml * Fixed SwiftLint warnings with some minor refactors. * Revert "Fixed SwiftLint warnings with some minor refactors." This reverts commit 2c19802. * Revert "Added line length to .swiftlint.yml" This reverts commit 12a6781. * Revert "Exclude catalog/third_party from SwiftLint." This reverts commit 8a00ad8. * [Collections] Added custom Storyboard cell to the Storyboard example. (#1152) * [Feature highlight] Dynamically size inner highlight (#1151) * Use instance based inner radius * Warning re ios sim * Scale outer highlight to encircle inner highlight * Dont scale innerhighlight pulsing with inner highlight size * Reset highlight example supplemental: * Build fix: CGFloat casts missing from MDCFeatureHighlightView.m. * More SwiftLint fixes for unit tests and example apps. (#1154) * ClangFormat changes. * Added swiftlint to scripts/format_all.` * Fix scripts/lint_all to work from any directory. * Fixed swiftlint invocation. * Remove the checks for force casting (! operator). * Some fixes. * More Swift fixes. * [Snackbar] Message View Styling. (#1120) * Snackbar Message View Styling. * Small alteration to how colors are generated for the unit tests. * Not styling the snack bar in the init method. * Default styling for background views. * Remove overriding the styling in init. * Looks like swiftlint is already installed by default on travis-ci boxes. Trying this as an experiment. * Trying this? * Cant get unit tests to pass as there’s no window to add the message view to with logic tests. * Fixed Shrine compilation. * [AppBar] - Added Modal Presentation App Bar Example (#1153) * ModalAppBar - Added additional AppBar example to display modal AppBar vc example * ModalAppBar - Added swift modal example * ModalAppBar - Updated naming * ModalAppBar - Updated swift example * ModalAppBar - Indentions and removed setting nil to title property * Moves the initialization of the header page into separate file * Moves the initialization of the header page into separate file
brianjmoore
pushed a commit
to brianjmoore/material-components-ios
that referenced
this pull request
Jan 23, 2017
* [Docs] Add hero image to top-level README.md (material-components#1100) * Added hero image. * Added retina-sized hero image. * Add `srcset` image tag. * Flow image to the right. * Update README.md * Fixed srcset, duh. * Update README.md * Update README.md * Gave up on srcset+markdown for now. * Update README.md * Update README.md * Increased image size. * Remove redundant RTL frame adjustment (material-components#1103) * Made build/test scripts exit with failure if anything failed. (material-components#1088) * [ReadMes] - First image of each component is too big (material-components#1110) * MDC_#917 - Activity Indicator Readme Update * MDC_#917 - Updated remaining readme image links * MDC_#917 - Fixed typo * [Site] Removing unused files for and from generated doc site. (material-components#1108) * [ReadMes] - Updated asset name for collection_cells (material-components#1111) * Enable Travis CI integration (material-components#1095) * Add file to kick off Travis * Checking Travis CI's installed Xcode and simulator devices. * Adding Cocoapods init to Travis CI config. * Enabling building in Travis CI config. * Added temporary dumping of the log file on error. * Switched Shrine to manual signing. * Dump Travis code signing options. * Adding CocoaPods version to debug output. * Remove code signing reporting from Travis CI config. * Forcing `build_all` to skip code signing. * Switching Shrine back to automatic provisioning style. * Re-enabling testing in Travis CI. * Bump up verbosity of testing. * Changing test device from 10.2 to 10.1 to work around Travis CI bug. * Remove the printing of available devices, Xcode will print them out on error. * Added more context on failure for Travis CI builds only. * Re-enable CI for our normal branches. * Remove "do not merge" file. * Removing our development team and switching Catalog to automatic profiles. * Removing our development team and switching Bare to automatic profiles. * Removing our development team and switching Pesto to automatic profiles. * Add Travis CI build badge to README.md (material-components#1112) * Add uploading of testing code coverage results to codecov.io (material-components#1114) This won't do anything yet, but once we start emitting code coverage files it will. * Enable test code coverage reports in Xcode and in Travis CI. (material-components#1115) * Add codecov.io badge to README.md. (material-components#1116) * Add Codecov config to exclude uninteresting paths. (material-components#1118) * Extracts header code into method removing repetition (material-components#1119) * [AppBar] Header stack view in AppBarController (material-components#1121) Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet. * Initial implementation of MDCTabBar and private MDCItemBar (material-components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * Initial implementation of MDCTabBar and private MDCItemBar (material-components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * [Tabs] Initial README template and changes * [Tabs] Updating intro content. * [Tabs] Commenting out mention of bottom navigation bars in readme. * [Tabs] Overview written * [Tabs] Correcting resources key in pod spec. * [Tabs] Correcting implementation of resources key in pod spec. * [Tabs] Mentioning badges in overview. * [Tabs] Removing TODO in ready. * [Tabs] Removing duplicate entry in pod spec (cherry pick artifact.) * [Tabs] Duplicating tabs example in prep for splitting it into two. * [Tabs] Examples crudely split apart. * [Pods] Update of lock, catalog and tests for new version. * [Tabs] Refactored examples to be in style of supplemented examples. * [Tabs] Formatting. * [Tabs] Formatting. * [Tabs] Formatting. * Add usage examples * Add usage examples * Update import documentation * Small edits * Do not show badges for title-only tabs Also updates the text-only example to toggle upcasing rather than increment non-existent badges. * Update title-only documentation re: badges * Update README.md * Update Podfile.lock * Manually fix Podfile.lock
willlarche
pushed a commit
that referenced
this pull request
Jan 25, 2017
* Initial implementation of MDCTabBar and private MDCItemBar (#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * [Tabs] Initial README template and changes * [Tabs] Updating intro content. * [Tabs] Commenting out mention of bottom navigation bars in readme. * Initial implementation of MDCTabBar and private MDCItemBar (#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * [Tabs] Initial README template and changes * [Tabs] Updating intro content. * [Tabs] Commenting out mention of bottom navigation bars in readme. * [Tabs] Correcting resources key in pod spec. * [Tabs] Correcting implementation of resources key in pod spec. * [Tabs] Removing duplicate entry in pod spec (cherry pick artifact.) * [Tabs] Overview written * [Tabs] Mentioning badges in overview. * [Tabs] Removing TODO in ready. * [Tabs] Duplicating tabs example in prep for splitting it into two. * [Tabs] Examples crudely split apart. * [Pods] Update of lock, catalog and tests for new version. * [Tabs] Refactored examples to be in style of supplemented examples. * [Tabs] Formatting. * [Tabs] Formatting. * [Tabs] Formatting. * Add usage examples * Add usage examples * Fix bad merge * Update import documentation * Small edits * Do not show badges for title-only tabs Also updates the text-only example to toggle upcasing rather than increment non-existent badges. * Update title-only documentation re: badges * Update README.md * Update Podfile.lock * Manually fix Podfile.lock * Feature tabs rebase from develop (#7) * [Docs] Add hero image to top-level README.md (#1100) * Added hero image. * Added retina-sized hero image. * Add `srcset` image tag. * Flow image to the right. * Update README.md * Fixed srcset, duh. * Update README.md * Update README.md * Gave up on srcset+markdown for now. * Update README.md * Update README.md * Increased image size. * Remove redundant RTL frame adjustment (#1103) * Made build/test scripts exit with failure if anything failed. (#1088) * [ReadMes] - First image of each component is too big (#1110) * MDC_#917 - Activity Indicator Readme Update * MDC_#917 - Updated remaining readme image links * MDC_#917 - Fixed typo * [Site] Removing unused files for and from generated doc site. (#1108) * [ReadMes] - Updated asset name for collection_cells (#1111) * Enable Travis CI integration (#1095) * Add file to kick off Travis * Checking Travis CI's installed Xcode and simulator devices. * Adding Cocoapods init to Travis CI config. * Enabling building in Travis CI config. * Added temporary dumping of the log file on error. * Switched Shrine to manual signing. * Dump Travis code signing options. * Adding CocoaPods version to debug output. * Remove code signing reporting from Travis CI config. * Forcing `build_all` to skip code signing. * Switching Shrine back to automatic provisioning style. * Re-enabling testing in Travis CI. * Bump up verbosity of testing. * Changing test device from 10.2 to 10.1 to work around Travis CI bug. * Remove the printing of available devices, Xcode will print them out on error. * Added more context on failure for Travis CI builds only. * Re-enable CI for our normal branches. * Remove "do not merge" file. * Removing our development team and switching Catalog to automatic profiles. * Removing our development team and switching Bare to automatic profiles. * Removing our development team and switching Pesto to automatic profiles. * Add Travis CI build badge to README.md (#1112) * Add uploading of testing code coverage results to codecov.io (#1114) This won't do anything yet, but once we start emitting code coverage files it will. * Enable test code coverage reports in Xcode and in Travis CI. (#1115) * Add codecov.io badge to README.md. (#1116) * Add Codecov config to exclude uninteresting paths. (#1118) * Extracts header code into method removing repetition (#1119) * [AppBar] Header stack view in AppBarController (#1121) Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet. * Initial implementation of MDCTabBar and private MDCItemBar (#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * Initial implementation of MDCTabBar and private MDCItemBar (#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update * [Tabs] Initial README template and changes * [Tabs] Updating intro content. * [Tabs] Commenting out mention of bottom navigation bars in readme. * [Tabs] Overview written * [Tabs] Correcting resources key in pod spec. * [Tabs] Correcting implementation of resources key in pod spec. * [Tabs] Mentioning badges in overview. * [Tabs] Removing TODO in ready. * [Tabs] Removing duplicate entry in pod spec (cherry pick artifact.) * [Tabs] Duplicating tabs example in prep for splitting it into two. * [Tabs] Examples crudely split apart. * [Pods] Update of lock, catalog and tests for new version. * [Tabs] Refactored examples to be in style of supplemented examples. * [Tabs] Formatting. * [Tabs] Formatting. * [Tabs] Formatting. * Add usage examples * Add usage examples * Update import documentation * Small edits * Do not show badges for title-only tabs Also updates the text-only example to toggle upcasing rather than increment non-existent badges. * Update title-only documentation re: badges * Update README.md * Update Podfile.lock * Manually fix Podfile.lock * [Tabs] Making delegate methods all optional. (#8) * [Tabs] Now that protocol has optional methods, putting in safety for the method calls. (#9) * [Tabs] Small changes for UIAppearance support. * [Tabs] Formatting examples. * [Tabs] Changed icon example to be an appBar’s bottomBar. * [Tabs] Styling of examples. * [Tabs] Example layout correction. * [Tabs] Example update. * [Tabs] Example has more ‘content’. * [Tabs] Removing unused delegate method in example. * [Tabs] Formatting of code for style. * [Tabs] Better unselected style choice in icon example. * [Tabs] More content in example vies. * [Tabs] iOS 8 support for icons example. * [Tabs] Still image. * [Tabs] Video added. * [Tabs] Renaming for clarity. * [Tabs] Correcting comment. * [Tabs] Better organization of example view creation methods. * [Tabs] Cleaning up imports in example. * [Tabs] Better code for incrementing badge in example. * [Tabs] Using local variable vs @Property in example * [Tabs] Example format correction. * [Tabs] Alphabetizing lists in examples. * [Tabs] Example code style improvement. * [Tab] Example NSAssert. Safety. * [Tabs] Comments and clarity in example. * [Tabs] clang-format in examples. * [Tabs] Text color correction in example. * [Tabs] Catalog tile. * [Tabs] clang-format in tile. * [Tabs] Adding IBOutlet for delegate (optional.) * [Tabs] Fix 32-bit build * [Tabs] Interface Builder example. * [Tabs] Beginning Swift example. * [Tabs] More swift example content. * [Tabs] Swift example complete * [Tabs] Swift example PR note implementations. * [Tabs] Swift formatting * [Tabs] Formatting in example * [Tabs] Formatting swift example. * [Tabs] Swift example clarity. * [Tabs] Example wrapping revert. * [Tabs] Example wrapping revert. * Fixes from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the header stack view is going to be laid out with auto layout, it should be inited with a CGRectZero. Doing it with self.view.bounds creates a tiny loop since the view is not loaded yet.
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationcloses #1234Contributing has more information and tips for a great
pull request.