[Internal] Deprecate compat ViewOverlay #4483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubiqq
force-pushed
the
internal/remove-compat-view-overlay
branch
from
d1f1fec to
ca324d9
Compare
Open
pubiqq
force-pushed
the
internal/remove-compat-view-overlay
branch
from
ca324d9 to
2963a18
Compare
|
ah sorry, I missed this PR and only saw #4736 which is being synced internally currently |
|
since that is a restricted API it should be ok to removed it, thank you for considering that though! will close this now as it was closed in 65e5f1a |
Also, this API is public and I don't think it's ok to remove it without following a deprecation strategy. There are over 600 places in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.