-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Fix anchors #4015
[Docs] Fix anchors #4015
Conversation
Were these anchors broken or are you just changing them to title case? |
They are still broken, try clicking on the "Design & API Documentation" link here, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f56bf9e
to
fea356a
Compare
I'm not sure adding an extra |
Well, you can compare the current version with the proposed one yourself. You don't think I just added hyphens to random places for no reason, right? 😂 Or I can just replace all the ampersands in the headings with "and", as you wish. |
Ah, I only tested internally where we have the docs and there the current link works and the new one doesn't, but on github I see now it's the opposite. Sometimes there are discrepancies like this with github so changing to Side note - of course I didn't think you'd do a change for no reason, but misunderstandings and mistakes can happen from both sides. Let's cultivate a respectful environment here :) |
Ok, deal. |
No description provided.