[NavigationRailView] Start insets only use the system bars instead of the system bar and display cutout insets

[t895]

Description: The navigation rail applies start insets only based on the system bars. This results in the rail appearing behind display cutouts. This component used to change its start insets based on the system bars and the display cutout.

Expected behavior: Apply start insets based on the system bars and display cutout

Source code:

material-components-android/lib/java/com/google/android/material/navigationrail/NavigationRailView.java

Line 216 in a2309ce

ViewUtils.isLayoutRtl(view) ? systemBarInsets.right : systemBarInsets.left;

Minimal sample app repro: https://github.com/t895/yuzu/tree/material-update

Android API version: API 34

Material Library version: 1.10.0+ The bug was introduced with this commit

Device: Samsung Galaxy S21 and Google Pixel 7 both running their latest stable software updates as of 1/11/24

[michael-winkler]

Still wrong on 1.13.0-alpha09

[michael-winkler]

@drchen @manabu-nakamura Please fix this. Thank you very much :)

[manabu-nakamura]

Sorry, I can't understand this issue.

[tfonteyn]

@manabu-nakamura https://developer.android.com/develop/ui/views/layout/edge-to-edge

[michael-winkler]

See here:
#3991

[manabu-nakamura]

I don't know whether NavigationRailView itself have to dodge the display cutout or not. Tell me some documentation.

Test10.zip
(before #3991)


(after #3991) The NavigationRailView is under the system navigation bar.

[manabu-nakamura]

#4006 ([Catalog] window overlaps with cutout area in landscape mode) was committed 1 year ago...

[michael-winkler]

From Google News. There is padding where the display cutout area is.

[manabu-nakamura]

Thank you. But it's not clear from just looking at this screenshot whether the NavigationRailView itself automatically have to dodge the display cutout or not.

https://developer.android.com/develop/ui/views/layout/display-cutout#best-practices:

Be mindful of the placement of critical elements of the UI. Don't let the cutout area obscure any important text, controls, or other information.

We (app developers) may need to manually dodge the display cutout if necessary...

[michael-winkler]

Thats' right but if we want to handle it by ourself we need to do it like this:

android:fitsSystemWindows="false"

and then:

ViewCompat.setOnApplyWindowInsetsListener(navigationRailView) { view, windowInsets ->
    val insets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars() + WindowInsetsCompat.Type.displayCutout())

    navigationRailView.updatePadding(
        left = insets.left,
        bottom = insets.bottom
    )

    ViewCompat.onApplyWindowInsets(view, windowInsets)
}

But why should we do it like this if a fix of the wrong values see here:
https://github.com/material-components/material-components-android/pull/3991/files

is enough?