-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MaterialCardView add ripple drawable to foreground
PiperOrigin-RevId: 208993686
- Loading branch information
Showing
2 changed files
with
61 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.0 is out, why hasn't this been merged in?
the new component still have no ripple effect?
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey you are correct.
We are releasing 1.1.0-alpha01 this week which will include this.
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this fix also be released in the old support library which is currently on version 28.0.0?
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the 1.x path is stable, fixes for the Design library (and any other androidx support library) will not be released for the 28.x path. 28.0.0 is the last version there.
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what version of com.android.support:design:xxxxx should be to fix the bug with ripple drawable on foreground?
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OleksandrGrument this bug is on material components not the design library.
and it is sated a few comments above this that the fix has been released with 1.1.0-alpha01 of material components for android
09673a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if its included in 1.0.0. I am not able to see the ripple effect