refactor: review typescript signature #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Oct 8, 2023
| @@ -31,13 +31,17 @@ type FastifyOramaPluginOptions = { | |||
|
|
|||
| declare const fastifyOrama: FastifyPluginCallback<FastifyOramaPluginOptions> | |||
|
|
|||
| interface OramaApi<T> { | |||
test/types/index.test-d.ts
Outdated
| @@ -1,9 +1,9 @@ | |||
| import { expectType } from 'tsd' | |||
| import {expectType} from 'tsd' | |||
There was a problem hiding this comment.
what is the linting here?
Suggested change
| import {expectType} from 'tsd' | |
| import { expectType } from 'tsd' |
|
@mateonunez and @Eomm seems the CI is stick! I don't have any permission on it, but can one of you check it or restart the job? |
The action gets stuck with Node v20 here: 
|
|
CI passed. |
|
Okay, I don't know how. I had the same problem locally with node 20. |
|
Let's see what @Eomm says, then I think we can merge it into the |
Eomm
approved these changes
Oct 10, 2023
mateonunez
pushed a commit
that referenced
this pull request
Oct 17, 2023
* breaking: migrate to cjs * fix: typescript interface * refactor: review typescript signature (#164) --------- Co-authored-by: Luca Del Puppo <Puppo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Eomm and @mateonunez, I reviewed a little the typescript interface and removed the
getOramamethod.In this way, there is only one decorator, and if someone wants to use typescript, using the
withOrama<T>()get the FastifyInstance with the correct type and with theoramadecorator set up.