Skip to content

Commit

Permalink
Using GET by default (although configurable) in search forms. Fixes l…
Browse files Browse the repository at this point in the history 
…iferay#846.
  • Loading branch information
@4lejandrito
4lejandrito committed Apr 25, 2018
1 parent e8b765a commit 0716784
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 30 deletions.
9 changes: 9 additions & 0 deletions packages/clay-management-toolbar/src/ClayManagementToolbar.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,15 @@ ClayManagementToolbar.STATE = {
*/
searchActionURL: Config.string(),

/**
* Method of the search form.
* @default GET
* @instance
* @memberof ClayManagementToolbar
* @type {?(string|undefined)}
*/
searchFormMethod: Config.string().value('GET'),

/**
* Name of the search form.
* @default undefined
Expand Down
6 changes: 5 additions & 1 deletion packages/clay-management-toolbar/src/ClayManagementToolbar.soy
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
]>}
{@param? id: string}
{@param? searchActionURL: string}
{@param? searchFormMethod: string}
{@param? searchFormName: string}
{@param? searchInputName: string}
{@param? searchValue: string}
Expand Down Expand Up @@ -141,6 +142,7 @@
{param disabled: $disabled /}
{param filterItems: $filterItems /}
{param searchActionURL: $searchActionURL /}
{param searchFormMethod: $searchFormMethod /}
{param searchFormName: $searchFormName /}
{param searchInputName: $searchInputName /}
{param searchValue: $searchValue /}
Expand Down Expand Up @@ -541,6 +543,7 @@
{param disabled: $disabled and not $searchValue /}
{param onlySearch: $onlySearch /}
{param searchActionURL: $searchActionURL /}
{param searchFormMethod: $searchFormMethod /}
{param searchFormName: $searchFormName /}
{param searchInput kind="html"}
{call .searchInput}
Expand Down Expand Up @@ -746,6 +749,7 @@
{@param? disabled: bool}
{@param? onlySearch: bool}
{@param? searchActionURL: string}
{@param? searchFormMethod: string}
{@param? searchFormName: string}
{@param? searchInput: html}
{@param? searchInputName: string}
Expand All @@ -757,7 +761,7 @@
action="{$searchActionURL}"
{/if}

method="POST"
method="{$searchFormMethod}"
{if $searchFormName}
name="{$searchFormName}"
{/if}
Expand Down
58 changes: 29 additions & 29 deletions packages/clay-management-toolbar/src/__tests__/__snapshots__/ClayManagementToolbar.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ exports[`ClayManagementToolbar should render a disabled management toolbar 1`] =
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -214,7 +214,7 @@ exports[`ClayManagementToolbar should render a disabled management toolbar with
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text" value="carcamusas">
Expand Down Expand Up @@ -376,7 +376,7 @@ exports[`ClayManagementToolbar should render a management toolbar with a clear r
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text" value="foo">
Expand Down Expand Up @@ -548,7 +548,7 @@ exports[`ClayManagementToolbar should render a management toolbar with advanced
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -606,7 +606,7 @@ exports[`ClayManagementToolbar should render a management toolbar with ascending
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -658,7 +658,7 @@ exports[`ClayManagementToolbar should render a management toolbar with classes 1
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -725,7 +725,7 @@ exports[`ClayManagementToolbar should render a management toolbar with creation
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -790,7 +790,7 @@ exports[`ClayManagementToolbar should render a management toolbar with creation
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -843,7 +843,7 @@ exports[`ClayManagementToolbar should render a management toolbar with creation
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -915,7 +915,7 @@ exports[`ClayManagementToolbar should render a management toolbar with creation
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1019,7 +1019,7 @@ exports[`ClayManagementToolbar should render a management toolbar with descendin
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1091,7 +1091,7 @@ exports[`ClayManagementToolbar should render a management toolbar with filters d
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1173,7 +1173,7 @@ exports[`ClayManagementToolbar should render a management toolbar with filters d
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1276,7 +1276,7 @@ exports[`ClayManagementToolbar should render a management toolbar with filters d
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1365,7 +1365,7 @@ exports[`ClayManagementToolbar should render a management toolbar with filters d
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1463,7 +1463,7 @@ exports[`ClayManagementToolbar should render a management toolbar with id 1`] =
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1529,7 +1529,7 @@ exports[`ClayManagementToolbar should render a management toolbar with info butt
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1614,7 +1614,7 @@ exports[`ClayManagementToolbar should render a management toolbar with links as
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1727,7 +1727,7 @@ exports[`ClayManagementToolbar should render a management toolbar with search ac
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form action="mySearchURL" method="POST" role="search">
<form action="mySearchURL" method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1764,7 +1764,7 @@ exports[`ClayManagementToolbar should render a management toolbar with search fo
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" name="mySearchName" role="search">
<form method="GET" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1801,7 +1801,7 @@ exports[`ClayManagementToolbar should render a management toolbar with search in
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1850,7 +1850,7 @@ exports[`ClayManagementToolbar should render a management toolbar with search re
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text" value="foo">
Expand Down Expand Up @@ -1932,7 +1932,7 @@ exports[`ClayManagementToolbar should render a management toolbar with search re
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text" value="foo">
Expand Down Expand Up @@ -2061,7 +2061,7 @@ exports[`ClayManagementToolbar should render a management toolbar with selection
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2123,7 +2123,7 @@ exports[`ClayManagementToolbar should render a management toolbar with sorting h
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2205,7 +2205,7 @@ exports[`ClayManagementToolbar should render a management toolbar with view type
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2298,7 +2298,7 @@ exports[`ClayManagementToolbar should render a managment toolbar with creation m
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2335,7 +2335,7 @@ exports[`ClayManagementToolbar should render a managment toolbar without creatio
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2363,7 +2363,7 @@ exports[`ClayManagementToolbar should render the default markup 1`] = `
<div class="container-fluid container-fluid-max-xl">
<ul class="navbar-nav"></ul>
<div class="navbar-form navbar-form-autofit">
<form method="POST" role="search">
<form method="GET" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" placeholder="Search for..." ref="search" type="text">
Expand Down

0 comments on commit 0716784

Please sign in to comment.