Implement Tabs component #1416
Implement Tabs component #1416
Conversation
There was a problem hiding this comment.
Review Summary
Hi! 👋 There are a couple of small things we need to address. In src/App.jsx, you can directly use tabs instead of creating an extra tabsArr variable. Also, in src/components/Tabs/Tabs.jsx, make sure to add the key prop to the <li> element when rendering the tabs. This helps React efficiently update the list! Once these are fixed, the code will be perfect! 👍
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
There was a problem hiding this comment.
Review Summary
The code looks good overall! 🎉 You've correctly implemented the Tabs component and are passing the required props. The key prop and onTabSelected logic are also well-handled. The final conclusion confirms that you're directly using the tabs array, which is exactly what was intended. Keep up the excellent work and continue building upon these solid foundations! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
DEMO LINK