add task solution #1775
add task solution #1775
Conversation
There was a problem hiding this comment.
Review Summary
Great job building the counter application! All the buttons work correctly and produce the expected numerical output. I'm requesting one change to align the implementation of the increase function with the task description.
The requirement specifies that the increase function should first call addOne() and then, in a separate step, check if the count is divisible by 5 to call add100(). Your current logic checks the condition before calling the update functions. While this works due to how React state updates are batched, it's important to follow the specified sequence.
Please adjust your increase function to call addOne() unconditionally at the beginning, and then perform the check for calling add100(). This is a subtle but important detail. You've done great work here, and this small fix will make it perfect!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
There was a problem hiding this comment.
Review Summary
Excellent work! I am approving your solution. You've successfully addressed the feedback from the previous review, and the logic for the increase button is now perfectly aligned with the task requirements. The application is fully functional, and the code is clean and readable. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK