a #1755
a #1755
Conversation
There was a problem hiding this comment.
Review Summary
I am requesting changes because the Increase button’s logic breaks the required behavior. In src/App.jsx, the increase handler (around the lines where it checks divisibility before calling addOne) uses the pre-increment count to decide whether to add 100, which violates the requirement to increment first and then, based on the updated value, conditionally add 100. This will not produce the required sequence (e.g., 101, 102, 103, 104, 105, 206, …) and will likely fail tests. To fix: compute the next value first and then apply the conditional in a single functional setCount, for example: set using prev => { const next = prev + 1; return next % 5 === 0 ? next + 100 : next; }. Also, please run the tests and ensure they pass, and add the required demo link in the PR description if your task requires it. Minor note: the optional 6-line style suggestion is not met [optional], but it’s not a blocker. Nice work wiring the buttons and using functional updaters for addOne/add100—once you fix the Increase ordering, you should be good to go.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const add100 = () => { | ||
| // write code here | ||
| }; | ||
| const addOne = () => setCount(prev => prev + 1); |
There was a problem hiding this comment.
Checklist item violated (optional code-style): "[CODE STYLE] - try to solve the task in 6 lines of code (optional) :)"
This file is longer than 6 lines. The item is optional, but per the checklist I must report it when violated.
|
The task specifies not to touch this function at all, accept the code as it is. |
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
4 participants
https://vasyarusnak.github.io/react_counter-js/