Skip to content

added task solution #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added task solution #790

wants to merge 3 commits into from

Conversation

@LabPetro
Copy link

Anastasiia-Svintsova
Anastasiia-Svintsova suggested changes May 17, 2023
View reviewed changes
src/style.css Outdated
@@ -1 +1,12 @@
/* styles go here */
.duo {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more descriptive class name instead of 'duo'. For example, 'form-group'.

src/style.css Outdated
margin-bottom: 20px;
}

.quads {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more descriptive class name instead of 'quads'. For example, 'form-block'.

src/index.html Outdated
id="review"
name="rating"
step="1"
max="0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max attribute of the 'review' input should be greater than the min attribute. It doesn't work
image

src/index.html Outdated
class="duo"
type="text"
id="surname"
name="info"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute should be more descriptive, e.g. 'surname' instead of 'info'.

src/index.html Outdated
class="duo"
type="text"
id="name"
name="information"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute should be more descriptive, e.g. 'name' instead of 'information'.

src/index.html Outdated
Comment on lines 22 to 27
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the code style everywhere

Suggested change
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"

src/index.html Outdated

<div class="duo">
<label for="cat">Do you love cats?</label>
<input
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a label to each radio button. It doesn't work correctly now

Screen.Recording.2023-05-17.at.13.49.21.mov

src/index.html
Comment on lines 150 to 152
</div>

</fieldset>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>
</fieldset>
</div>
</fieldset>

src/index.html Outdated
Comment on lines 187 to 189
<button
type="submit"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button
type="submit"
>
<button type="submit">

src/style.css Outdated
margin-bottom: 10px;
}

fieldset {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use classes for styling

agniya-i
agniya-i suggested changes May 18, 2023
View reviewed changes
src/index.html Outdated
Comment on lines 96 to 109
<label for="yes">Yes</label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
<label for="no">No</label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<label for="yes">Yes</label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
<label for="no">No</label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
<label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
Yes
</label>
<label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
No
</label>

You can wrap it into label tag to fix previous comment

src/index.html Outdated
Comment on lines 146 to 153
<input type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<input type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>
<input
type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>

src/index.html Outdated
Comment on lines 163 to 167
<textarea name="write"
id="comments"
autocomplete="off"
required
></textarea>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<textarea name="write"
id="comments"
autocomplete="off"
required
></textarea>
<textarea
name="write"
id="comments"
autocomplete="off"
required
></textarea>

src/index.html Outdated
Comment on lines 176 to 177
<option value="answer">Yes</option>
<option value="answer">No</option>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<option value="answer">Yes</option>
<option value="answer">No</option>
<option value="yes">Yes</option>
<option value="no">No</option>

@LabPetro LabPetro requested a review from agniya-i May 18, 2023 22:55
Anastasiia-Svintsova
Anastasiia-Svintsova approved these changes May 19, 2023
View reviewed changes
src/index.html
Comment on lines +15 to +17
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post">
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post"
>

src/index.html
Comment on lines +18 to +19

<fieldset class="container">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add spaces between parent and child components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agniya-i agniya-i Awaiting requested review from agniya-i

1 more reviewer

@Anastasiia-Svintsova Anastasiia-Svintsova Anastasiia-Svintsova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LabPetro @agniya-i @Anastasiia-Svintsova