Don't count hidden pages for the sub-menus #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2021
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
the high timeout caused glitches so we assume the width has been settled in the next animation frame + plus some surplus matcornic#470
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix if you only have hidden pages in your sub-menu you will get an empty
<ul></ul>that makes the menu entry a little bit taller than the others