Remove code that adjusts navigation margin #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for this beautiful theme. I however noticed something odd, which is that this
adjustForScrollbar
function does not seem to be doing anything under regular usage, but it is getting in my way when I try to customize my home page. I'll explain.The code adds a ~15px margin to the right navigation arrow then the
#body-inner
height is near the same height as#body
. The intent appears to be to detect when the scrollbar is present on-screen, but because#body
is a div that contains#body-inner
, and therefore content added to#body-inner
affects the height of both divs, this condition will continue to always evaluate tofalse
. I checked this on pages that required scrolling, and sure enough the margin of the right-nav was still 0.So for the above reason I believe the code can be removed, since it doesn't seem to be serving its intended purpose. Please let me know if I misevaluated the purpose.
The reason I came across this is that I am trying to customize my home page in a way that it creates a banner that is flush with the top of the page. In doing so I have removed the
83px
margin, which is now triggering this code to add a margin to the left nav, and it looks wrong.