Feature/sof-7954 Feat: Interfacial Energy WF#141
Merged
Conversation
| name: PseudopotentialMethod | ||
| model: | ||
| name: DFTModel | ||
| name: Run Interface SCF |
Member
There was a problem hiding this comment.
SCF -> Total Energy
We should not need this subworkflow at all, if needed, we can generalize the logic to be reusable across VBO and Interface Energy and other future workflows
| @@ -0,0 +1,76 @@ | |||
| # Fetch precomputed film bulk total energy from a finished Total Energy job. | |||
Member
There was a problem hiding this comment.
This needs to be done through reusable subworkflows
| @@ -0,0 +1,85 @@ | |||
| # Loads a material by its position in a multi-material job and assigns the | |||
Member
There was a problem hiding this comment.
We should either use this for VBO too (and any other multi-material wfs) or not use at all
…ding Splits each bulk reference's loading into an explicit "Load X Material" stage (shell/utils/get_material_by_index, reused rather than duplicated) followed by a trimmed shell/fetch_bulk_total_energy that only looks up the already-resolved material's total energy. Addresses PR review: reuse get_material_by_index consistently, and stop duplicating the bulk-loading logic per material slot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
timurbazhirov
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.