chore/SOF-7951 Chore: use utils instead of code/utils#288
Open
VsevolodX wants to merge 6 commits into
Open
Conversation
VsevolodX
changed the title
timurbazhirov
requested changes
Jul 4, 2026
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
Member
There was a problem hiding this comment.
Let's use standata in tests?
Member
Author
There was a problem hiding this comment.
Ok. I think I did that on other commit... Let me reapply
| import { Cell } from "../cell/cell"; | ||
| import { ATOMIC_COORD_UNITS, HASH_TOLERANCE } from "../constants"; | ||
|
|
||
| const { math } = Utils; |
Member
There was a problem hiding this comment.
Elsewhere we usually use Utils.math inside the code instead of just "math" for clarity
Member
Author
There was a problem hiding this comment.
I figured this would have less change -- just 2 lines, not many per file.
But I can do that if that's how we want it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code/utils changed to utils
also JS uses banker's rounding like Python -- to resolved hashes for materials correctly