Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback if we can't fetch HTML #59

Merged
merged 1 commit into from
Mar 8, 2021
Merged

fallback if we can't fetch HTML #59

merged 1 commit into from
Mar 8, 2021

Conversation

gurgeous
Copy link
Contributor

@gurgeous gurgeous commented Mar 5, 2021

See #47. I removed TestParsingInexistentSite & TestParsingEmptyResponse since they no longer apply - we will fetch default icons for those cases.

@mat mat merged commit 159d276 into mat:master Mar 8, 2021
@mat
Copy link
Owner

mat commented Mar 8, 2021

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants