Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goreleaser error #241

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix goreleaser error #241

merged 2 commits into from
Feb 10, 2025

Conversation

masutaka
Copy link
Owner

@masutaka masutaka commented Feb 10, 2025

PR Type

🤖 Generated by PR Agent at 8ce07b4

['Bug fix', 'Enhancement']

PR Description

🤖 Generated by PR Agent at 8ce07b4

  • Fixed deprecated property usage in .goreleaser.yaml.
  • Reverted version bump to 4.2.34 in lib/version.go.
  • Removed changelog entries for version 4.2.34.

PR Walkthrough

Relevant files
Bug fix
version.go
Revert version bump to `4.2.33`                                                   

lib/version.go

  • Reverted the version from 4.2.34 to 4.2.33.
+1/-1     
Enhancement
.goreleaser.yaml
Fix deprecated property in `.goreleaser.yaml`                       

.goreleaser.yaml

  • Fixed deprecated archives.format property.
  • Updated to use archives.formats array.
  • +1/-1     
    Documentation
    CHANGELOG.md
    Remove changelog for version `4.2.34`                                       

    CHANGELOG.md

    • Removed changelog entries for version 4.2.34.
    +0/-14   

    Other Information

    I guess I was unaware of the destructive changes in goreleaser's update from v5 to v6.

    I don't want to create a broken release, so I reverted the commits in the v4.2.34 release PR and removed the git tags. I am not sure if this is the correct way to handle a failed release in tagpr.


    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • This reverts commit 2af611d, reversing
    changes made to aafbe8f.
    $ make release
    goreleaser check
      • checking                                 path=.goreleaser.yaml
      • DEPRECATED:  archives.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat for more info
      • .goreleaser.yaml                                 error=configuration is valid, but uses deprecated properties
      ⨯ command failed                                   error=1 out of 1 configuration file(s) have issues
    make: *** [Makefile:93: release-check] Error 2
    Error: Process completed with exit code 2.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change

    Verify that the new archive format configuration using 'formats' array instead of 'format' property works correctly with goreleaser and produces the expected zip archives

    - formats: [ "zip" ]

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @masutaka masutaka added the bug label Feb 10, 2025
    @masutaka masutaka merged commit 8fc97c5 into main Feb 10, 2025
    10 checks passed
    @masutaka masutaka deleted the fix-release-job branch February 10, 2025 13:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant