Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engine #1755

Merged
merged 11 commits into from
Feb 7, 2025
Merged

Remove engine #1755

merged 11 commits into from
Feb 7, 2025

Conversation

abhiaiyer91
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
assistant-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20am
bird-checker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20am
crypto-chatbot 🛑 Canceled (Inspect) Feb 7, 2025 5:20am
mastra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20am
mastra-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20am
openapi-spec-writer ❌ Failed (Inspect) Feb 7, 2025 5:20am
travel-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20am

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 3b406b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

promptless bot commented Feb 7, 2025

✅ No documentation updates required.

                        Promptless's comment below: 

After reviewing these pages, I can see that:

  1. The engine.mdx page needs to be removed since the engine feature is being removed.

  2. The agent memory page (01-agent-memory.mdx) is already up to date - it focuses on the storage and vector store implementations directly rather than going through the engine abstraction.

  3. The RAG overview page is also up to date - it doesn't mention the engine at all, focusing instead on the direct vector store implementations.

Let me check if there are any other pages that might need updates by searching for "engine" in the doc tree. Looking at the results, I see that we need to:

  1. Remove the engine.mdx page from local-dev (already being done in the PR)
  2. Update the _meta.ts file to remove the engine entry (already being done in the PR)

No other documentation changes appear to be necessary, as the engine abstraction seems to have been an implementation detail that wasn't heavily documented outside of its own page. The main functionality (storage and vector operations) is still available through direct implementations.

I'll respond to the user with this analysis.

The PR removes the "engine" feature from Mastra, which was an abstraction layer over PostgreSQL-based storage for agent memory and vector operations. This change appears to be a simplification of the architecture, where these features are now handled directly through storage and vector store implementations rather than through the engine abstraction.

The only documentation change needed is the removal of the engine.mdx page and its entry in _meta.ts, which is already being handled in the PR. No other documentation updates are necessary since:

  1. The agent memory documentation already focuses on direct storage implementations
  2. The RAG documentation already uses direct vector store implementations
  3. The engine abstraction wasn't heavily documented outside of its own page

The core functionality (storage and vector operations) remains available through direct implementations, so this appears to be primarily an internal architectural change that simplifies the codebase.

@vercel vercel bot temporarily deployed to Preview – openapi-spec-writer February 7, 2025 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – crypto-chatbot February 7, 2025 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – travel-ai February 7, 2025 04:56 Inactive
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Braintrust eval report

No experiments to report

@vercel vercel bot temporarily deployed to Preview – mastra-docs February 7, 2025 04:58 Inactive
Copy link

socket-security bot commented Feb 7, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@radix-ui/react-radio-group@1.2.2 None +10 282 kB chancestrickland

🚮 Removed packages: npm/@vercel/analytics@1.4.1, npm/framer-motion@11.18.2, npm/jsdom@25.0.1, npm/vite@6.0.11, npm/vitest@2.1.8

View full report↗︎

@vercel vercel bot temporarily deployed to Preview – mastra-docs February 7, 2025 05:02 Inactive
@abhiaiyer91 abhiaiyer91 merged commit 1f87ee6 into main Feb 7, 2025
11 of 18 checks passed
@abhiaiyer91 abhiaiyer91 deleted the removeEngine branch February 7, 2025 05:03
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Braintrust eval report

No experiments to report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant