-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add persistance to Postresql container #887
Conversation
Same goes for redis :
|
Does docker-compose automatically create these folders on the host, or do you have to create them yourself? Or does docker-compose complain if they're not there? For the record when this option is not specified, the contains still use volumes, they're just anonymous volumes that are hard to find later. |
@Gargron docker-compose is smart and does all the magic for you. :) |
In that case please add @Wonderfall's suggested addition and I will merge |
I think it's a better idea to specify the path for volumes, for easy backup for example. |
This will break on local development in a vm (aka mac), since they wont have the right permissions. |
So why not create a specific dev compose file ? |
While this is a good change for new installations, I have realized (the hard way from an admin trying this out) that this will make docker-compose break previous installations during update. I am reverting this until we can figure out how to not brick people's existing configurations. |
Is @Wonderfall's redis addition really necessary? Because I'm one of those admins who lost their db because of a |
@jemus42 |
add persistance to Postresql container
…d_characters Ignore exception of invalid characters
Merge upstream changes
Create a volume for Postgres datas. Because if you kill all containers without this volume, all users are losts.