Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nanobox] Apply Release Notes Changes #5670

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

danhunsaker
Copy link
Contributor

Apparently I missed some things in earlier commits/releases that needed to be applied to the Nanobox setup. All minor things, nothing that breaks anything, but still best to get them in place.

  • Move cron jobs to their own component, so the Sidekiq component can be scaled up to multiple instances without causing issues with running the same cron job multiple times at once.
  • Update cron jobs to the latest requirements
  • Add new variables to .env.nanobox
  • Update Nginx to use correct cache header directives

@danhunsaker danhunsaker force-pushed the improve/nanobox-for-v2 branch from 8b66c30 to 99a487c Compare November 13, 2017 01:36
boxfile.yml Outdated
network_dirs:
data.storage:
- public/system

cron:
- id: generate_static_gifs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, hold on. Are these run as cron? They are not regular tasks.. They were upgrade one-offs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any mention of when to run them - or not - so they've been hiding in the background for a while, now. Will happily remove whichever ones I can! It's pretty clear you at least mean the task to generate a static image from a gif; does this apply to any of the others as well?

@danhunsaker danhunsaker force-pushed the improve/nanobox-for-v2 branch 2 times, most recently from 6e06602 to 72baa0a Compare November 13, 2017 09:29
boxfile.yml Outdated
@@ -131,6 +144,10 @@ worker.sidekiq:
schedule: '30 00 * * *'
command: 'bundle exec rake mastodon:push:clear'

- id: update_remote_avatars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this one

Copy link
Contributor Author

@danhunsaker danhunsaker Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a mechanism for relaying avatar changes through the Fediverse as they happen, then? I'd like to show my users the current avatar of anyone they follow, and this appears to be the only way to make it happen, so I'd want to comment it out rather than remove it entirely if there's no alternative already in place.

Copy link
Member

@Gargron Gargron Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, obviously. This cron CLI command is for troubleshooting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it state that, exactly? This is the only place I've seen that mentioned...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@danhunsaker danhunsaker Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see redownload_avatars listed in that doc at all.

boxfile.yml Outdated
data.storage:
- public/system

cron:
- id: update_counter_caches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done automatically as well, then? Or do the docs just not explain its purpose very well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CLI command has been used in the upgrade when counter caches were first introduced and needed to be filled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool. Consider it gone.

boxfile.yml Outdated
- id: do_daily_tasks
schedule: '00 00 * * *'
command: 'bundle exec rake mastodon:daily'

- id: clear_silenced_media
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very subjective on whether you want to run this or not. Do you want to delete stuff shadowbanned people upload? Part of the appeal of the "silence" feature is that it's a more or less invisible quarantine for the person who's in it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll comment this one out and leave a note on when it might be desirable to enable it, then. 👍

Apparently I missed some things in earlier commits/releases that needed to be applied to the Nanobox setup. All minor things, nothing that breaks anything, but still best to get them in place.

- Move cron jobs to their own component, so the Sidekiq component can be scaled up to multiple instances without causing issues with running the same cron job multiple times at once.
- Update cron jobs to the latest requirements, removing extraneous ones
- Add new variables to `.env.nanobox`
- Update Nginx to use correct cache header directives
@danhunsaker danhunsaker force-pushed the improve/nanobox-for-v2 branch from 72baa0a to a102e8a Compare November 15, 2017 05:33
@Gargron Gargron merged commit 3e4b01b into mastodon:master Nov 15, 2017
@danhunsaker danhunsaker deleted the improve/nanobox-for-v2 branch November 15, 2017 16:09
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017
Apparently I missed some things in earlier commits/releases that needed to be applied to the Nanobox setup. All minor things, nothing that breaks anything, but still best to get them in place.

- Move cron jobs to their own component, so the Sidekiq component can be scaled up to multiple instances without causing issues with running the same cron job multiple times at once.
- Update cron jobs to the latest requirements, removing extraneous ones
- Add new variables to `.env.nanobox`
- Update Nginx to use correct cache header directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants