Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/MultipleComparison #33313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nschonni
Copy link
Contributor

Rule was disabled in the Rubocop update for a bad autocorrect. That bug that @mjankowski reported upstream got fixed in 1.69.2 in #33283

@@ -29,9 +29,6 @@ Style/IfUnlessModifier:
Style/KeywordArgumentsMerging:
Enabled: false

Style/MultipleComparison:
Enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-correct is fine, but I'd probably leave this disabled.

Co-authored-by: Matt Jankowski <matt@jankowski.online>
@mjankowski mjankowski added ruby Pull requests that update Ruby code lint fix 💅 labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint fix 💅 ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants