Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Content Warning and filters #32543

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

ClearlyClaire
Copy link
Contributor

This removes the stripes, adjust the borders accordingly, widen the click area and slightly rework the styling and wording

Before

image
image

After

image
image

@ClearlyClaire ClearlyClaire added ui Front-end, design area/web interface Related to the Mastodon web interface labels Oct 16, 2024
@ClearlyClaire ClearlyClaire marked this pull request as ready for review October 16, 2024 14:18
@ClearlyClaire ClearlyClaire linked an issue Oct 16, 2024 that may be closed by this pull request
@renchap renchap requested a review from Gargron October 17, 2024 09:29
@antimundo antimundo mentioned this pull request Oct 21, 2024
Copy link

@antimundo antimundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and has been highly requested in #32352

Thanks! :))

@renchap renchap added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 393f0a0 Oct 23, 2024
38 checks passed
@renchap renchap deleted the redesign/content-warning-filters branch October 23, 2024 09:57
@Izorkin
Copy link
Contributor

Izorkin commented Oct 27, 2024

Is it possible to make CW framing customizable in user settings?

@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Nov 19, 2024
@omentic
Copy link

omentic commented Nov 23, 2024

Hello! Thanks for this change, it is much appreciated. My instance started running it and I have some minor feedback. The full content warning modal is rather large, two lines at the least, while content titles themselves are typically rather short. This makes for a lot of unused space. I think it would be nicer if the show/hide modal was on the same line as the title, especially since a lot of the posts on my timeline have content titles (people use it for shop talk, politics, etc).

This is what the current design looks like:
2024-11-22-114302

Here is a mockup of what this could like instead, with the content icon removed (for space) and the "show/hide post" dialog on the same line as the title:
2024-11-22-114359

If this is desired, I can open a PR. I am going to be writing the CSS for this anyway as a change to my home instance.

@antimundo
Copy link

I like your proposal @omentic and I agree that the current modal feels too large

@pwarren
Copy link

pwarren commented Nov 30, 2024

Hello! Thanks for this change, it is much appreciated. My instance started running it and I have some minor feedback. The full content warning modal is rather large, two lines at the least, while content titles themselves are typically rather short. This makes for a lot of unused space. I think it would be nicer if the show/hide modal was on the same line as the title, especially since a lot of the posts on my timeline have content titles (people use it for shop talk, politics, etc).

If this is desired, I can open a PR. I am going to be writing the CSS for this anyway as a change to my home instance.

I would at least like the custom CSS for my instance please, I've fiddled around with a flexbox on .content-warning, but can't make it look right yet (has been a decade since I did HTML/CSS)

@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web interface Related to the Mastodon web interface ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert: #31365
6 participants