-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when accepting appeal for sensitive posts deleted in the meantime #32037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the coverage here go on the services spec and add this edge case ... or is there some outcome/aspect of this that's really only visible at the controller level despite the change being in the service?
This can definitely go in the service spec. EDIT: done |
382f53c
to
b1cdcaa
Compare
Co-authored-by: David Roetzel <david@roetzel.de>
When a moderator tries to accept an appeal for a mark-statuses-as-sensitive action but the statuses have been suspended in the meantime, the controller would error out because it is trying to undo the change on the status, creating a
StatusEdit
in the process.This would fail with:
Because of the default scope on
Status
.An alternative could be to unscope the default scope in
StatusEdit
'sbelongs_to
…