Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unchangeable filtered notification setting for limited accounts #31324

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Aug 7, 2024

In #30559, we changed notifications from limited accounts to end up in filtered notifications, but this was not made clear in the UI.

This PR introduces an unchangeable filtered notifications “setting” to mention this case.

image

It would also make sense to change this to an actual setting in the future, especially if we end up adding an option to drop notifications outright for a category.

@ClearlyClaire ClearlyClaire added the ui Front-end, design label Aug 7, 2024
@ClearlyClaire ClearlyClaire requested a review from a team August 7, 2024 15:08
@ClearlyClaire ClearlyClaire force-pushed the add-unchangeable-setting-for-limited-accounts branch from 55b8f32 to ddd2b0e Compare August 7, 2024 15:12
@Gargron
Copy link
Member

Gargron commented Aug 7, 2024

I think this should be the last option in the list.

@ClearlyClaire ClearlyClaire force-pushed the add-unchangeable-setting-for-limited-accounts branch from ddd2b0e to 80497be Compare August 7, 2024 17:05
@ClearlyClaire
Copy link
Contributor Author

Moved.

@Gargron Gargron added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit f862936 Aug 7, 2024
28 checks passed
@Gargron Gargron deleted the add-unchangeable-setting-for-limited-accounts branch August 7, 2024 23:20
justinwritescode pushed a commit to justinwritescode/mastodon that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants