Remove packages that are provided by Heroku stacks #19836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineffyble
added
the
deployment
|
Might fix #20591. |
|
I wonder if Mastodon is working on |
Gargron
approved these changes
Dec 15, 2022
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to clean up the
Aptfileremoving the deb packages that are provided by Heroku stacks. For me it seems to be better not explicitly list packages because some might become inconsistent with those provided by the stack (e.g., #19807 broke my builds onheroku-20stack). Still, I think we'd need to wait for users of other platforms/stacks confirm this doesn't negatively impact their deploys: