Webfinger resource to extract username from resource string #1607
Conversation
app/lib/webfinger_resource.rb
Outdated
|
|
||
| def username | ||
| case resource | ||
| when /https/ |
There was a problem hiding this comment.
I'm thinking this should be /https?/
There was a problem hiding this comment.
Ah I missed that in the original ... so both of these strings should work?
http://example.com/users/name->namehttps://example.com/users/name->name
?
There was a problem hiding this comment.
Although your tests seem to account for the http case so I'm not sure what this regex does
There was a problem hiding this comment.
PR updated to reflect that https is supported.
mjankowski
force-pushed
the
webfinger-resource
branch
from
4513dcc to
c1e2684
Compare
app/lib/webfinger_resource.rb
Outdated
| case resource | ||
| when /\Ahttps?/i | ||
| username_from_url | ||
| when /acct/ |
There was a problem hiding this comment.
Thinking right now - You should be able to pass username@domain without the acct: in the front, and it should be able to deal with that. So maybe just make that the else condition.
There was a problem hiding this comment.
I should have submitted that as a change request - this should be able to handle username@domain without the acct: at the front
mjankowski
force-pushed
the
webfinger-resource
branch
2 times, most recently
from
c688e00 to
b130e70
Compare
app/lib/webfinger_resource.rb
Outdated
| case resource | ||
| when /\Ahttps?/i | ||
| username_from_url | ||
| when /acct/ |
There was a problem hiding this comment.
I should have submitted that as a change request - this should be able to handle username@domain without the acct: at the front
mjankowski
force-pushed
the
webfinger-resource
branch
from
9810e1a to
3296fb6
Compare
mjankowski
force-pushed
the
webfinger-resource
branch
from
3296fb6 to
8ccf68e
Compare
|
Updated to handle the simple |
…#1607) * Add WebfingerResource class to extract usernames * Use WebfingerResource in xrd#webfinger
* Add WebfingerResource class to extract usernames * Use WebfingerResource in xrd#webfinger
I noticed the logic in this controller contained a reference to
params_path[:controller] == 'users'which I think must be for outdated code (that route no longer exists?). I extracted the logic to pull out a username from a resource to it's own class, and added specs for the strings I'm guessing this is supposed to handle.Feedback on whether that list of strings is exhaustive and sufficient would be appreciated!