Workaround paste crash on iOS 14.x issue #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
reviewed
Dec 1, 2022
| nextResponder.perform(#selector(UIResponderStandardEditActions.paste(_:)), with: sender) | ||
| // fix #660 | ||
| // https://github.com/mastodon/mastodon-ios/issues/660 | ||
| if #available(iOS 15.0, *) { |
There was a problem hiding this comment.
That could be cool! iOS 15 also lets us use things like AsyncPublisher to do interop between async sequences and Combine.
There was a problem hiding this comment.
👍 on iOS >= 15 for me as well. I like to pursue n-1 for supported OSes, and given iOS 15 is supported by such a large percentage of device, I personally don't s a reason not to bump.
There was a problem hiding this comment.
(iOS 15 supports all devices that iOS 14 supports IIRC)
There was a problem hiding this comment.
If we update the minimal version in the next build. The iOS 14.x still could install the app but only for v1.4.7.
Maybe we fix this bug and push as v1.4.8. Then update the min OS in v1.5.0. So this issue not bother old OS users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #660
Paste anything in post compose scene on iOS 14.5+ will crash the app. However, it's normal on iOS 15.0+ and iOS 16.0+. It looks like the paste image feature intro in #486 is somehow not working on iOS 14.x.
Just disable it for iOS 14.x to work around the crash problem.
Reproduce the issue on iPad mini 5 with iOS 14.8.