Improve min radius when editing spot. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The min radius was a hardcoded value of 1 whatever unit, regardless of the pixel size. This caused problems on images where the pixel size was much smaller than 1 µm for instance. Here the min radius is determined to be half of the smallest pixel size in the image, so that spots edited manually always have a size of at least 1 of the smallest pixel in diameter. Fix #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min radius was a hardcoded value of 1 whatever unit, regardless of the pixel size. This caused problems on images where the pixel size was much smaller than 1 µm for instance.
Here the min radius is determined to be half of the smallest pixel size in the image, so that spots edited manually always have a size of at least 1 of the smallest pixel in diameter.
Fix #142