fix: returns right var name in all cases

mastilver · Jul 20, 2017 · adcd2b9 · adcd2b9
1 parent 7d34004
commit adcd2b9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -77,7 +77,7 @@ export default class ModulesCdnWebpackPlugin {
         if (isModuleAlreadyLoaded) {
             const isSameVersion = this.modulesFromCdn[modulePath].version === version;
             if (isSameVersion) {
-                return modulePath;
+                return this.modulesFromCdn[modulePath].var;
             }
 
             return false;

diff --git a/test/core.js b/test/core.js
@@ -417,7 +417,11 @@ test('when using multiple versions of a module, make sure the right version is u
     t.true(includes(files, 'app.js'));
     t.true(includes(files, 'https://unpkg.com/react@15.6.1/dist/react.js'));
 
-    const output = await fs.readFile(path.resolve(__dirname, './fixtures/output/multiple-versions/app.js'));
+    let output = await fs.readFile(path.resolve(__dirname, './fixtures/output/multiple-versions/app.js'));
+    output = output.toString();
+
+    const numberOfExports = output.match(/module\.exports =/g).length;
+    t.is(numberOfExports, 1);
 
     // NOTE: not inside t.false to prevent ava to display whole file in console
     const doesIncludeReact14 = includes(output, 'THIS IS REACT@0.14.9!');