Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set useNativeDriver to false explicitly in animation and reset #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blindibrasil
Copy link

@blindibrasil blindibrasil commented Apr 20, 2020

#339 - Solution:
I believe that the proposal submitted earlier does not fully solve the problem presented in version 0.62 of the RN. Because it is necessary to insert useNativeDriver in the function that resets the action.
https://reactnative.dev/blog/2017/02/14/using-native-driver-for-animated#how-do-i-use-this-in-my-app

I believe that the proposal submitted earlier does not fully solve the problem presented in version 0.62 of the RN. Because it is necessary to insert useNativeDriver in the function that resets the action.

https://reactnative.dev/blog/2017/02/14/using-native-driver-for-animated#how-do-i-use-this-in-my-app
@sam1463
Copy link

sam1463 commented May 17, 2020

If you wanted to, I imagine you could even add an optional prop for ActionButton of useNativeDriver, which would default to false. And then use that value in the two spots you changed, rather than a hard-coded false. Idk if there are cases where people would want it to be true for this component, but just a thought.

@blindibrasil
Copy link
Author

@mastermoo or @sibelius
Could you verify and merge the correction of this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants