Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Touch fix (iPhone 6++++): Add "rejectResponderTermination" prop to Touchables #267

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

IgorVanian
Copy link
Contributor

No description provided.

@mastermoo
Copy link
Owner

I can't find this prop rejectResponderTermination in the official react native docs?
Also I can't reproduce this issue on a real device. Is this really an issue that needs to be fixed?

@IgorVanian
Copy link
Contributor Author

IgorVanian commented Jan 15, 2019

I can't find this prop rejectResponderTermination in the official react native docs?
Also I can't reproduce this issue on a real device. Is this really an issue that needs to be fixed?

Actually it's not in the docs but I still have to use it in my project because absolute touchables are bugged with 3D touch...

See:
facebook/react-native#13845
facebook/react-native#10386 (comment)

https://medium.com/@mikeshi/react-native-swipeouts-textinputs-animations-and-gesture-responders-a6baa4745735 CTRL+F rejectResponderTermination

@akepecs
Copy link

akepecs commented Mar 11, 2019

@IgorVanian @mastermoo Is there anything holding back this PR from being merged?

I have noticed the action button is frequently unresponsive on devices with 3D touch.

@mastermoo mastermoo merged commit 8df917c into mastermoo:master Jan 3, 2020
@IgorVanian IgorVanian deleted the 3DTouch-fix branch November 14, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants