Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centering and shadows on android fixed with prop fixNativeFeedbackRadius #228

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Centering and shadows on android fixed with prop fixNativeFeedbackRadius #228

wants to merge 2 commits into from

Commits on Oct 14, 2017

  1. Centering and shadows on android fixed with prop fixNativeFeedbackRad… 

    …ius.

When setting fixNativeFeedbackRadius to true and giving the ActionButton position 'Center'. The AtionButton and ActionButtonItems would have an offset from the center due to incorrect styling.

fixNativeFeedbackRadius also caused an ugly shadow on ActionButtonItems and their respective lable, and also a cropped dropshadow.

For the ActionButtonItem, this was due to the shadow styling was set on the wrong element for android. As for the lable, we do not need to set the fixNativeFeedbackRadius to the touchableBackground (the lable is rectangular anyway). You'll notice that the ripple effect on the lable would extend in a circular fashion outside the borders of the lable.
    @micnil
    micnil committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    a37ce1e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. solved merge conflict

    @micnil
    micnil committed Dec 19, 2017
    1 Configuration menu
    Copy the full SHA
    f27528a View commit details
    Browse the repository at this point in the history