Order of operation issue with _unmarshal_json_object#7
Merged
jbonzo merged 1 commit intomassive-com:masterfrom Jan 6, 2020
Merged
Order of operation issue with _unmarshal_json_object#7jbonzo merged 1 commit intomassive-com:masterfrom
jbonzo merged 1 commit intomassive-com:masterfrom
Conversation
Collaborator
|
Hey @moilanen thanks for contributing to this repo. The change you're proposing makes sense but do you mind show an example input as well as a before and after output? We are currently working on fixing our CI system, otherwise a test would be more appropriate. |
Contributor
Author
|
Sure thing. I'm on Python 3.7.5 on Mac. Here's my test and results: Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During an unmarshal the attribute_name was getting set to an empty string. Looks to be an order of operation issue w/ the string append.