Conversation
jbonzo
reviewed
Apr 28, 2021
Collaborator
jbonzo
left a comment
jbonzo
left a comment
There was a problem hiding this comment.
Could you change the reference tickers from vx to v3. Just the List endpoint, not the details endpoint
suremarc
force-pushed
the
new-reference-endpoints
branch
from
92236e1 to
ee27cc0
Compare
jbonzo
approved these changes
Apr 29, 2021
suremarc
force-pushed
the
new-reference-endpoints
branch
from
ee27cc0 to
7342610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the new reference ticker endpoints and their corresponding types to the python client. I tested the functions myself and everything looks good AFAICT -- feel free to test it yourself.