Merged
Conversation
antdjohns
requested review from
a team,
aitzkovitz,
chaig15,
joedursun and
suremarc
and removed request for
a team
antdjohns
force-pushed
the
ws-rest-indices
branch
from
b78d012 to
94b15fd
Compare
aitzkovitz
reviewed
Mar 9, 2023
Contributor
|
looks good, you'll also need to update the UnderlyingAsset class in rest/models/snapshot.py to include a |
chaig15
approved these changes
Mar 9, 2023
Contributor
|
lgtm |
aitzkovitz
approved these changes
Mar 9, 2023
jbonzo
reviewed
Mar 10, 2023
antdjohns
force-pushed
the
ws-rest-indices
branch
from
197284a to
b4e08e7
Compare
jbonzo
approved these changes
Mar 10, 2023
Collaborator
jbonzo
left a comment
jbonzo
left a comment
There was a problem hiding this comment.
Just one thing but looks good
Contributor
Author
what's the one thing? am I good to merge? |
antdjohns
force-pushed
the
ws-rest-indices
branch
from
b4e08e7 to
78b11be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.