feat: provide custom json module#306
feat: provide custom json module#306clickingbuttons merged 8 commits intomassive-com:masterfrom at-cf:master
Conversation
clickingbuttons
left a comment
There was a problem hiding this comment.
Thanks for contributing. Code looks good! Just need to add :param custom_json: Your explanation to the doc comments and a better type than Any. Bonus points for an example.
clickingbuttons
left a comment
There was a problem hiding this comment.
Looks awesome! Thanks for contributing :)
|
Once you fix the tests and lint this should be good. Run |
Sorry, I am on win64 and it looks like you guys are set up for unix, so I can't easily use your scripts. I committed some fixes. |
|
Hey @at-cf. It looks like this PR just needs some minor linting fixes. If you don't respond or don't have time I'll resolve them later this week and merge. |
clickingbuttons
left a comment
There was a problem hiding this comment.
I fixed this up and it's good to merge. I just had to poetry add -D orjson and I was able to import from it directly. Since the package doesn't have types I had to add # type: ignore before it.
see #305