Skip to content

Add currency_symbol, base_currency_name, and base_currency_symbol attributes to TickerDetails class. #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielatpolygonio merged 2 commits into from
Jun 28, 2022
Merged

Add currency_symbol, base_currency_name, and base_currency_symbol attributes to TickerDetails class. #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7143d07
add currency_symbol, base_currency_name, and base_currency_symbol att…
danielatpolygonio Jun 28, 2022
1369a7a
also in the from_dict method
danielatpolygonio Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions polygon/rest/models/tickers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from typing import Optional, List

from ...modelclass import modelclass


Expand Down Expand Up @@ -78,6 +79,9 @@ class TickerDetails:
cik: Optional[str] = None
composite_figi: Optional[str] = None
currency_name: Optional[str] = None
currency_symbol: Optional[str] = None
base_currency_name: Optional[str] = None
base_currency_symbol: Optional[str] = None
delisted_utc: Optional[str] = None
description: Optional[str] = None
ticker_root: Optional[str] = None
Expand Down Expand Up @@ -109,6 +113,9 @@ def from_dict(d):
cik=d.get("cik", None),
composite_figi=d.get("composite_figi", None),
currency_name=d.get("currency_name", None),
currency_symbol=d.get("currency_symbol", None),
base_currency_name=d.get("base_currency_name", None),
base_currency_symbol=d.get("base_currency_symbol", None),
delisted_utc=d.get("delisted_utc", None),
description=d.get("description", None),
ticker_root=d.get("ticker_root", None),
Expand Down