Skip to content

fix financials and add example #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clickingbuttons merged 2 commits into from
May 11, 2022
Merged

fix financials and add example #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
134e8d9
fix financials and add example
clickingbuttons May 11, 2022
43f96c2
style
clickingbuttons May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions examples/rest/financials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from polygon import RESTClient

client = RESTClient()

financials = client.get_ticker_details("NFLX")
print(financials)
12 changes: 8 additions & 4 deletions polygon/rest/models/tickers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,18 @@


@dataclass
class Address:
class CompanyAddress:
"Contains address data for a ticker detail."
address1: Optional[str] = None
address2: Optional[str] = None
city: Optional[str] = None
state: Optional[str] = None
country: Optional[str] = None
postal_code: Optional[str] = None

@staticmethod
def from_dict(d):
return Address(**d)
return CompanyAddress(**d)


@dataclass
Expand Down Expand Up @@ -69,7 +71,7 @@ def from_dict(d):
class TickerDetails:
"TickerDetails contains data for a specified ticker symbol."
active: Optional[bool] = None
address: Optional[Address] = None
address: Optional[CompanyAddress] = None
branding: Optional[Branding] = None
cik: Optional[str] = None
composite_figi: Optional[str] = None
Expand Down Expand Up @@ -98,7 +100,9 @@ class TickerDetails:
def from_dict(d):
return TickerDetails(
active=d.get("active", None),
address=None if "address" not in d else Address.from_dict(d["address"]),
address=None
if "address" not in d
else CompanyAddress.from_dict(d["address"]),
branding=None if "branding" not in d else Branding.from_dict(d["branding"]),
cik=d.get("cik", None),
composite_figi=d.get("composite_figi", None),
Expand Down
4 changes: 2 additions & 2 deletions test_rest/test_tickers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
TickerTypes,
Publisher,
Branding,
Address,
CompanyAddress,
)
from base import BaseTest

Expand Down Expand Up @@ -93,7 +93,7 @@ def test_get_ticker_details(self):
details = self.c.get_ticker_details("AAPL")
expected = TickerDetails(
active=True,
address=Address(
address=CompanyAddress(
address1="ONE APPLE PARK WAY",
city="CUPERTINO",
state="CA",
Expand Down