Fix missing param in get_ticker_details#165
Closed
tehcoderer wants to merge 1 commit intomassive-com:masterfrom
Closed
Fix missing param in get_ticker_details#165tehcoderer wants to merge 1 commit intomassive-com:masterfrom
tehcoderer wants to merge 1 commit intomassive-com:masterfrom
Conversation
Missing `result_key` in `get_ticker_details`
|
Thanks for raising this to attention! We are about to release a new python client which will address this issue. |
Merged
Contributor
|
Thanks for the PR! Closing in favor of #166 which also fixes the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing
result_keyinget_ticker_detailshad me scratching my head for longer than I'd like to admit as it kept returning None's 🤣