Skip to content

Comments

User agent version#161

Merged
clickingbuttons merged 3 commits intomasterfrom
user-agent-version
May 6, 2022
Merged

User agent version#161
clickingbuttons merged 3 commits intomasterfrom
user-agent-version

Conversation

@clickingbuttons
Copy link
Contributor

@clickingbuttons clickingbuttons commented May 6, 2022

Also quick websocket test bugfix

@clickingbuttons clickingbuttons merged commit 9ace5b5 into master May 6, 2022
@clickingbuttons clickingbuttons deleted the user-agent-version branch May 6, 2022 14:33
headers={
"Authorization": "Bearer " + self.API_KEY,
"User-Agent": "Python client",
"User-Agent": "Python client " + version,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this matters, but I feel like making it all lowercase and hyphens instead of spaces will make querying/indexing on this attribute easier down the road.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morningvera Do you have opinions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants