-
Notifications
You must be signed in to change notification settings - Fork 9
Initial Implementation of Organizations #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
also fixed a typo
|
||
|
||
class Vendor(models.Model): | ||
class Affiliate(models.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest instead of Affiliate (which implies some affiliation, even its just a name) to call the base class Org
Fixed a redundant mention of service_area in filter_functions and added an allowed_users field in the Organization model class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Has the inherittance uncertainty been resolved yet? |
Summary / Highlights
Organization functionality has been implemented analogous to Vendor class; also added an Affiliate class in models.py that Vendor and Organization both inherit from (could eventually replace shared functionality in other Vendor and Organization files - would need to test the database). Closes #976.
Details (Give details about what this PR accomplishes, include any screenshots etc)
Taken from https://docs.google.com/document/d/1eHafgpwCL_A7oL0DgtIANvQLgwk2vG10zllVe9gphBk/edit?usp=sharing
Testing Steps (Provide details on how your changes can be tested)
Need to test whether the Organization entry is implemented in the database (and whether inheriting from Affiliate class causes problems); need to add front-end functionality for adding Organizations in admin site
Requirements (place an
x
in each[ ]
)Transparency (Project board)