[easy] Fix "tail: cannot open '2' for reading" #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These messages appear every time YABS is ran on a ZFS partition:
This is because of a typo in the command that gets the free space suffix ("T" for terabyte or "G" for gigabyte).
size_b
was always an empty string, which meant it failed theif
checks on line 535 and 542, which meant it always showed the warning (line 547).The fix was pretty simple.
For this particular
tail
call, bothtail -c2
andtail -c -2
are valid... I'm not sure what the original author intended. cc @webdock-io (#20).It could probably be implemented in a cleaner way by using
awk
for the entire thing instead of a mixture ofgrep
,awk
andtail
.