Skip to content

[REFACTOR] Could lua/mason/ui/instance.lua be factored out? #2087

@miEsMar

Description

@miEsMar

I've searched open issues for similar requests

  • Yes

Is your feature request related to a problem? Please describe.

By doing some tiny optimisation in lua/mason/ui/init.lua, I noticed it ended up being a simple wrapper around lua/mason/ui/instance.lua.

diff --git a/lua/mason/ui/init.lua b/lua/mason/ui/init.lua
index bbe534a..cf4f979 100644
--- a/lua/mason/ui/init.lua
+++ b/lua/mason/ui/init.lua
@@ -1,25 +1,23 @@
+local instance  = require "mason.ui.instance"
+
 local M = {}
 
-function M.close()
-    local api = require "mason.ui.instance"
-    api.close()
-end
+-- function M.close()
+--     instance.close()
+-- end
 
 function M.open()
-    local api = require "mason.ui.instance"
-    api.window.open()
+    instance.window.open()
 end
 
 ---@param view string
 function M.set_view(view)
-    local api = require "mason.ui.instance"
-    api.set_view(view)
+    instance.set_view(view)
 end
 
 ---@param tag any
 function M.set_sticky_cursor(tag)
-    local api = require "mason.ui.instance"
-    api.set_sticky_cursor(tag)
+    instance.set_sticky_cursor(tag)
 end
 
 return M

Describe the solution you'd like

So, why not inlining instance.lua in init.lua in the UI top-level component, and avoid one level of indirection?

Describe potential alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions